Repository navigation
chore: fix prompt-audit findings in knowledge through pixel-art - #16334
Conversation
Apply the verified prompt-audit edits for the knowledge, machine-health, markdown-format, mcp-tools, miro, multi-agent, mutation-testing, naming, overengineering, performance and pixel-art plugins: capital-letter emphasis lower-cased (ADR 0098), stale paths and facts corrected against the code, restated upstream facts replaced by pointers, and history notes removed. Code files change only in prompt, message or tool description strings. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The typos check reads "PNGs" as a misspelling; say "images" instead. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
Lane-Activity: pr-refine/fix-docs
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Chunk 1 of 3 (40 files)Security review: chunk 1 of 3 (40 files)No security issues found in this chunk. I read every hunk of all 40 files: the 11 What I checked:
Spend: none. No change to turn limits, models, schedules or runs. Chunk 2 of 3 (40 files)Security review: chunk 2 of 3 (40 files: machine-health through overengineering/findings-artifact.md)No security issues found in this chunk. I read every hunk of all 40 files. Almost all of the change is instruction text: emphasis lower-cased, upstream facts swapped for pointers, and doc facts aligned with the code. No Instruction-surface deletions and changes I checkedThe protected-class register was not read; each removed or changed rule was judged by its consequence.
Code files in this chunk
Evals
PR contextNothing in the PR description or the prior-findings file tells the lane what to do. Prior findings: no earlier heads were reviewed, so this was not a blocking-only review. Chunk 3 of 3 (17 files)Security review, chunk 3 of 3 (17 files)No security issues found in this chunk. I read every hunk of all 17 files: the overengineering, performance and pixel-art plugin docs and skill bodies, plus
critical-findings: 0 |
|
claude-review reviewed Chunk 1 of 3 (40 files)Code review: chunk 1 of 3 (40 files)No findings. I read every hunk of the 40 chunk-1 files: the 11 changelog fragments, the Most hunks only lower-case capital-letter emphasis or remove history notes. I checked that none of them changes what a rule requires: each prohibition and each must/never keeps its force, and no heading anchor changes. In Factual corrections checked against the code at head:
Changelog fragments: all 11 declare PR context: the PR closes no issue, so there are no acceptance criteria to check. Its description contains no embedded instructions aimed at this review. The verification the PR describes (test-suite passes, markdownlint, the sync and changelog checks) is the author's claim. I could not run any of it here. Verifier dropped 0 of 0 candidates. Chunk 2 of 3 (40 files)Chunk 2 of 3: no findings. I read every hunk of all 40 files in this chunk: machine-health, markdown-format, mcp-tools, miro, multi-agent, mutation-testing, naming and Most hunks only lower-case emphasis or headings, and none of them changes a rule's meaning. Every heading whose text changed keeps its anchor; for example, I checked each change of fact against the code it describes:
These checks come from reading the code. I did not run anything; the PR's own test results ( The chunk does not change any plugin manifest, and no Verifier dropped 0 of 0 candidates. Chunk 3 of 3 (17 files)Code review: chunk 3 of 3 (overengineering, performance, pixel-art)I read all 17 files in this chunk, every hunk. I found no blocking or advisory findings. What changed in this chunk
Observation (not counted as a finding): some source-run history lines were left in place, and they sit next to edited lines. Examples are Closing issue: none. The PR context says the work comes from an owner-requested audit, so there are no acceptance criteria to check against. Spend: none. Nothing in this chunk touches billing, runners, or lane budgets. Verifier dropped 0 of 0 candidates. critical-findings: 0 |
No related issue: prompt-audit findings from an owner-requested full-read audit
Summary
Group 6 of 10 from a full-read prompt audit, covering 11 plugins: knowledge, machine-health, markdown-format, mcp-tools, miro, multi-agent, mutation-testing, naming, overengineering, performance and pixel-art. The audit found instruction text written for older models, stale against the repository, or contradicted by another file. A second agent verified every edit before it reached this branch.
The change is instruction text except in six code files, where only a string changes:
plugins/knowledge/workflows/docpage-digest-batch.jsandplugins/multi-agent/workflows/drift-audit.js: one prompt string each, capital-letter emphasis lower-cased.plugins/miro/server/src/tools/bulk.tsandtags.ts: MCP tool descriptions now state the failure mode and return shape the handlers already have.plugins/performance/scripts/discriminate.pyandspawn-census.sh: refusal messages drop the story of an earlier run and keep the rule, its reason and the fix.Four eval files change: three
mcp-toolsgrader criteria drop a trailing parenthetical that repeated the criterion, and themulti-agentsu-apply-guard-off-confirmsexpected outcome drops a local-layer offer that its own description says cannot arise at a home root (no grader checks it).Fix
Test-Defender.ps1(tamper protection off is WARN; a detection is CRIT only without a recorded remediation), the remediation policy names thedisk-spacecheck and the first-run dry run, and the audit skill says the orchestrator writes the report and state files. course-digest's screenshot paths and referer header, and video-digest's key-frame folder and phase number, match the extractors.modelvalues, the effort cap, plugin auto-update, gh and benchmark tools).verify-api, read-only call only) instead of an undefined "explicit confirmation", which narrows the rule.No hunk was dropped or reverted: the patch applied cleanly on main, and no edit loosens a prohibition or safety rule. The
pr-refine/fix-docslane addedb52d695, replacing three figures of speech in overengineering and performance docs with plain wording.Verification
git apply --3wayof the group patch: all 86 files applied cleanly on99c790c93c.plugins/performance/scripts/discriminate.test.sh(38 pass) andspawn-census.test.sh(30 pass), which assert on the edited messages.scripts/sync-shared-copies.sh --check: all 904 copies match.scripts/check-changelog-fragments.sh --checkand--check-required origin/main: 11 valid fragments, one per touched plugin.discriminate.py.Related
N/A
Follow-ups
plugins/performance/scripts/README.mdL55 ("three of the five source-run failures") andplugins/performance/scripts/spawn-census.shL223 ("source failures 3 and 4"), per the claude-review lane's observation onb52d695; they do not affect behavior.🤖 Generated with Claude Code